fix get_current_namespace #302
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Maxusmusti
added
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
When testing this on an OSD Cluster I was unable to delete /var/run/secrets/kubernetes.io/serviceaccount/namespace because it is read only. I changed the code to look for a file that doesn't exist instead.
When creating an appwrapper after logging in via the token authentication in a Jupyter Notebook I got a ConfigException: Invalid kube-config file. No configuration found. error.
As things stand at the moment if a user lacks a config file and the namespace file there is an error when calling get_current_namespace() even if they have authenticated via the token and server with TokenAuthentication.
Issue link
closes #289
What changes have been made
Sometimes when the user has an api_client, they don't always want to search the serviceaccount. So this PR changes the
get_current_namespaceso that it always checks both the serviceaccount and kubeconfig for current namespaceVerification steps
Try logging out of cluster with
oc logoutand logging in throughTokenAuthentication. Callingget_current_namespaceshould yield the correct result. With the oldget_current_namespaceit would print that namespace is not availableChecks